Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-line entity id completion at first line #9

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Fix multi-line entity id completion at first line #9

merged 1 commit into from
Mar 22, 2019

Conversation

mickdekkers
Copy link
Contributor

position.line appears to be zero-based, so the entity id multi-line completions weren't triggering on the first line of the file. This PR should fix the issue 🙂

@keesschollaart81 keesschollaart81 merged commit 081554a into keesschollaart81:master Mar 22, 2019
@mickdekkers mickdekkers deleted the fix-entity-id-completion-first-line branch March 22, 2019 13:47
@keesschollaart81 keesschollaart81 mentioned this pull request Mar 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickdekkers @keesschollaart81